Skip to content

Conversation

johnjenkins
Copy link
Contributor

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@johnjenkins
Copy link
Contributor Author

@christian-bromann atm this is adding the <style /> as a sibling to the incoming component:

<style style-id="...">...</style>
<my-component>...</my-component>

Do you foresee any issue with that?
Or do you think it should be nested within the component?:

<my-component>
  <style style-id="...">...</style>
  ...
</my-component>

@christian-bromann
Copy link
Member

Do you foresee any issue with that?

I don't think it makes a difference as the browser will parses these styles anyway before anything else.

@christian-bromann
Copy link
Member

With #6260 we now export the style information as part of the HydrateResults object. @johnjenkins do you think this PR still makes sense for other use cases? The advantage of having it within the HyrdrateResults object is it allows me to just set the style tag once per component while the approach outlined in this PR would include the style tag for every appearance in the DOM.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants