-
Notifications
You must be signed in to change notification settings - Fork 815
feat(compiler): Allow consts for decorator arguments #6361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allows for consts to be used within Listen and Event decorators through additional type checks in compiler fixes: stenciljs#6360
thanks for contributing @jttommy - looks great! Do you mind:
TYSM |
Adds wdio test for event work. Runs linter and formatter Adds propery comments to address lint issues Addresses broken wdio config Removes quotes for test script to allow running in multiple envs fixes: stenciljs#6360
I believe I addressed the issues. WebDriverIO was giving me a lot of problems. I think those tests and that config need some work in another ticket. |
@johnjenkins
It seems the rendered Furthermore there is a failed test regarding |
hey thanks for looking at those @jttommy - I would say, as smelly as that test might seem, it's giving off some smoke with this MR. The wdio test you mentioned doesn't seem to ever be an issue in CI - so, yes probably a local thing. |
Limits decorator modifications to necessary decorators Listen and Event
I updated the code to only apply to |
…and testability. Fixes dynamic import workaround for circular dependency in decorator-utils. Adds comprehensive comments to wdio dynamic import tests for clarity.
@johnjenkins |
@johnjenkins I'm totally stuck on this JSON type error. Idk what the issue is exactly. Could I get some help on it? |
hey @tamb - ok will do when I get some time |
Allows for consts to be used within Listen and Event decorators through additional type checks in compiler
fixes: #6360
What is the current behavior?
GitHub Issue Number: (#6360)
What is the new behavior?
Documentation
Does this introduce a breaking change?
Testing
Other information