Skip to content

chore(npm): Update release npm action to stop using tokens #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(npm): Update release npm action to stop using tokens #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3117f5
Add icons to action steps
gnbm Oct 29, 2025
0724cb5
Update release yaml to use trusted publishers approach
gnbm Oct 29, 2025
d2c22e6
Added commit for temporary test
gnbm Oct 29, 2025
b59c34a
Update release.yml
gnbm Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:

permissions:
contents: write
id-token: write

jobs:
build_cli:
Expand Down Expand Up @@ -63,31 +64,33 @@ jobs:
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
steps:
- name: Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- uses: stenciljs/.github/actions/publish-npm@main
- name: 📦 Publish Dev Build
uses: stenciljs/.github/actions/publish-npm@e9945bdf51e97eee158513427ecf7be3d3a80443 # temp fix for trusted publishers
with:
tag: dev
version: ${{ needs.get_dev_version.outputs.dev-version }}
token: ${{ secrets.NPM_TOKEN }}

release_create_stencil_cli:
if: inputs.devRelease == 'no'
name: Publish Create Stencil CLI
name: 🚀 Publish Create Stencil CLI
needs: [build_cli]
runs-on: ubuntu-latest
permissions:
id-token: write
contents: write
steps:
- name: Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- uses: stenciljs/.github/actions/publish-npm@main
- name: 📦 Publish Release
uses: stenciljs/.github/actions/publish-npm@e9945bdf51e97eee158513427ecf7be3d3a80443 # temp fix for trusted publishers
with:
tag: latest
version: ${{ inputs.releaseType }}
token: ${{ secrets.NPM_TOKEN }}
github-token: ${{ secrets.GH_ADMIN_PAT }}
github-token: ${{ github.token }}


16 changes: 8 additions & 8 deletions .github/workflows/test-component-starter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,40 +15,40 @@ jobs:
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
runs-on: ${{ matrix.os }}
steps:
- name: Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Get Core Dependencies
- name: 🕸️ Get Core Dependencies
uses: stenciljs/.github/actions/get-core-dependencies@main

- name: Use Node ${{ matrix.node }}
- name: 🟢 Use Node ${{ matrix.node }}
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ matrix.node }}
cache: 'npm'

- name: Download Build Archive
- name: 📥 Download Build Archive
uses: stenciljs/.github/actions/download-archive@main
with:
name: stencil-cli
path: .
filename: stencil-cli-build.zip

- name: Initialize the Project
- name: 🔃 Initialize the Project
run: node index.js component tmp-component-starter
shell: bash

- name: Install Component Starter Dependencies
- name: 📦 Install Component Starter Dependencies
run: npm install
working-directory: ./tmp-component-starter
shell: bash

- name: Build Starter Project
- name: 🏗️ Build Starter Project
run: npm run build
working-directory: ./tmp-component-starter
shell: bash

- name: Test Starter Project
- name: 🧪 Test Starter Project
run: npm run test -- --no-build # the project was just built, don't build it again
working-directory: ./tmp-component-starter
shell: bash
Loading