Skip to content

chore(npm): Update release npm action to stop using tokens #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(npm): Update release npm action to stop using tokens #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2ebf3a
Update dependencies and fix associated issues and increase test coverage
gnbm Oct 30, 2025
568c61e
Update release yaml to use trusted publishers approach
gnbm Oct 30, 2025
c380d7f
Review peer dependencies
gnbm Oct 30, 2025
c8256c4
Update @types/node
gnbm Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- name: ⬇️ Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: 🐢 Setup Node ${{ matrix.node }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
- name: 🟢 Setup Node ${{ matrix.node }}
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ matrix.node }}
cache: 'npm'

- name: 🏗️ Install Dependencies
- name: 📦 Install Dependencies
run: npm ci

- name: 👷 Build
- name: 🏗️ Build
run: npm run build

- name: 🧪 Test jest
- name: 🧪 Test Jest
run: npm run test
24 changes: 11 additions & 13 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@ on:

jobs:
build:
name: Build
name: 🏗️ Build Eslint Stencil
uses: stenciljs/.github/.github/workflows/build.yml@main

get_dev_version:
if: inputs.devRelease == 'yes'
name: Get Dev Build Version
name: 🔍 Get Dev Build Version
runs-on: ubuntu-latest
outputs:
dev-version: ${{ steps.generate-dev-version.outputs.DEV_VERSION }}
steps:
- name: Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Generate Dev Version
- name: ⚙️ Generate Dev Version
id: generate-dev-version
run: |
PKG_JSON_VERSION=$(cat package.json | jq -r '.version')
Expand All @@ -55,34 +55,32 @@ jobs:

release_sass_stencil:
if: inputs.devRelease == 'yes'
name: Publish Dev Build
name: 📦 Publish Dev Build
needs: [build, get_dev_version]
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- name: Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- uses: stenciljs/.github/actions/publish-npm@main
- uses: stenciljs/.github/actions/publish-npm@e9945bdf51e97eee158513427ecf7be3d3a80443 # temp fix for trusted publishers
with:
tag: dev
version: ${{ needs.get_dev_version.outputs.dev-version }}
token: ${{ secrets.NPM_PAT_STENCIL_BOT }}

release_create_stencil_cli:
if: inputs.devRelease == 'no'
name: Publish Eslint Stencil
name: 📦 Publish Eslint Stencil
needs: [build]
runs-on: ubuntu-latest
permissions:
contents: write
id-token: write
steps:
- name: Checkout Code
- name: 📥 Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- uses: stenciljs/.github/actions/publish-npm@main
- uses: stenciljs/.github/actions/publish-npm@e9945bdf51e97eee158513427ecf7be3d3a80443 # temp fix for trusted publishers
with:
tag: latest
version: ${{ inputs.releaseType }}
token: ${{ secrets.NPM_PAT_STENCIL_BOT }}
github-token: ${{ secrets.GH_ADMIN_PAT }}
github-token: ${{ secrets.GITHUB_TOKEN }}
Loading