Skip to content

MessageDyn: Do not omit zero values on fields containing oneof #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MessageDyn: Do not omit zero values on fields containing oneof #660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
179496a
Do not omit zero values on fields containing oneof
mingyuchi Dec 5, 2022
f0662cc
Update mod.rs
mingyuchi Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion protobuf/src/reflect/dynamic/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ impl DynamicMessage {
RuntimeFieldType::Singular(..) => {
if let Some(v) = field_desc.get_singular(self) {
// Ignore default value for proto3.
if !is_proto3 || v.is_non_zero() {
if !is_proto3 || v.is_non_zero() || field_desc.containing_oneof().is_some()
{
handler.field(field_desc.proto().type_(), field_number, &v)?;
}
}
Expand Down