Allow to unset environment setting #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamink
force-pushed
the
allow-unset-environment
branch
from
034473c to
9218b8f
Compare
There was a problem hiding this comment.
for clarity, it would be nice to use if $environment == undef instead of if $environment != undef.
the != syntax is like a double-negative.
wrt undef semantics, @stephenrjohnson should clarify in README what undef should mean within context of configs. see thread at #63
There was a problem hiding this comment.
I agree. I was just following conventions used elsewhere in the manifest.
|
Per #63 I'm going to hold off on this till we sort out if my new way of setting config items will fly. |
stephenrjohnson
force-pushed
the
master
branch
2 times, most recently
from
7fa12de to
9f61425
Compare
stephenrjohnson
force-pushed
the
master
branch
from
cb745f4 to
c81cfa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some logic to optionally remove the environment setting from the
puppet.confby settingenvironment => undef.