Skip to content

test: add tests for mkAllPublic #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2024
Merged

test: add tests for mkAllPublic #51

merged 4 commits into from
Sep 5, 2024

Conversation

ddebrunner
Copy link
Contributor

@ddebrunner ddebrunner commented Aug 28, 2024 •
edited
Loading

Adds tests for protection/mkAllPublic including adding support for authTypes.noAuth by dropping the Authorization header

bobbiejc
bobbiejc approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@bobbiejc bobbiejc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Was wondering if there's a case to be made for testing same behavior with auth, but probably not.

@ddebrunner ddebrunner merged commit dfd12ca into main Sep 5, 2024
1 check passed
@ddebrunner ddebrunner deleted the mkall-tests branch September 5, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbiejc bobbiejc bobbiejc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddebrunner @bobbiejc