implement "strictness modes" for bean validation#30
Merged
Conversation
Review Summary by Qodo
WalkthroughsDescription• Introduce StrictnessMode enum with LogWarning and ThrowError options • Replace boolean flags with strictness mode parameters in validation modules • Implement conditional validation behavior based on strictness mode setting • Add SLF4J dependency and logging for constraint violation warnings File Changes1. ocpp-jaxb/src/main/java/de/rwth/idsg/ocpp/jaxb/validation/StrictnessMode.java
|
Code Review by Qodo
1. Breaking ctor signatures
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Comment on lines
+16
to
+23
| private final StrictnessMode strictnessMode; | ||
|
|
||
| @Override | ||
| public ValueSerializer<?> modifySerializer(SerializationConfig config, | ||
| BeanDescription.Supplier beanDesc, | ||
| ValueSerializer<?> serializer) { | ||
| if (serializer instanceof BeanSerializerBase) { | ||
| return new BeanSerializerWithValidation((BeanSerializerBase) serializer, validator); | ||
| return new BeanSerializerWithValidation((BeanSerializerBase) serializer, validator, strictnessMode); |
There was a problem hiding this comment.
1. Breaking ctor signatures 🐞 Bug ⛯ Reliability
Public validation modifier classes now require a StrictnessMode parameter, which is a source/binary incompatible change for any consumers constructing them directly. This can break downstream builds without a clear migration path.
Agent Prompt
### Issue description
Public classes `BeanSerializerModifierWithValidation` / `BeanDeserializerModifierWithValidation` (and related wrappers) changed constructor signatures due to adding `strictnessMode` as a new final field under Lombok `@RequiredArgsConstructor`. This is a breaking change for downstream consumers who instantiate these classes directly.
### Issue Context
The library already provides `BeanValidationModule` factories for typical use, so you can either (a) keep public constructors stable via overloads/defaults, or (b) reduce surface area by making internal classes non-public and exposing stable factory APIs.
### Fix Focus Areas
- ocpp-jaxb/src/main/java/de/rwth/idsg/ocpp/jaxb/validation/BeanSerializerModifierWithValidation.java[12-27]
- ocpp-jaxb/src/main/java/de/rwth/idsg/ocpp/jaxb/validation/BeanDeserializerModifierWithValidation.java[15-30]
- ocpp-jaxb/src/main/java/de/rwth/idsg/ocpp/jaxb/validation/BeanSerializerWithValidation.java[14-39]
- ocpp-jaxb/src/main/java/de/rwth/idsg/ocpp/jaxb/validation/BeanDeserializerWithValidation.java[17-67]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation: throwing exception and interrupting operation may not always be desirable.