Adapt style.css for mobile devices#1425
Draft
fnkbsi wants to merge 4 commits intosteve-community:masterfrom
Draft
Adapt style.css for mobile devices#1425fnkbsi wants to merge 4 commits intosteve-community:masterfrom
fnkbsi wants to merge 4 commits intosteve-community:masterfrom
Conversation
Add meta tag with viewport attribute to the html code. 00-charging-profile.jsp: At the removeRow button in periodsTable changed class=removeRow to id=removeRow. Add to both buttons in periodsTable the attribute class="btnScheduleRow" (use this class in css). In the snippet schedulePeriodsTable.js change the selector from class (.removeRow) to id (#removeRow)
Member
|
hey @fnkbsi are these changes finished and stable? |
Contributor
Author
|
@goekay: The style looks only good on some smartphones. I can't recommend to merge this PR in master. Currently I can't work on it, so should I delete the PR or keep it as inspiration for others? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a better administration of Steve from a mobile device the style.css could use some changes.
Add differentiation between mobile devices and desktop in style.css. Add meta tag with viewport attribute to the html code. 00-charging-profile.jsp: At the removeRow button in periodsTable changed class=removeRow to id=removeRow. Add to both buttons in periodsTable the attribute class="btnScheduleRow" (use this class in css). In the snippet schedulePeriodsTable.js change the selector from class (.removeRow) to id (#removeRow)