Skip to content

fix: elimante deprecated warings on nightly#457

Merged
stevearc merged 1 commit intostevearc:masterfrom
phanen:fix/deprecated-nightly
Jun 1, 2025
Merged

fix: elimante deprecated warings on nightly#457
stevearc merged 1 commit intostevearc:masterfrom
phanen:fix/deprecated-nightly

Conversation

@phanen
Copy link
Copy Markdown
Contributor

@phanen phanen commented Mar 30, 2025

- WARNING client.request is deprecated. Feature will be removed in Nvim
  0.13
  - ADVICE:
    - use client:request instead.
    - stack traceback: */aerial.nvim/lua/aerial/backends/lsp/init.lua:39
      */aerial.nvim/lua/aerial/backends/init.lua:124
      */aerial.nvim/lua/aerial/backends/init.lua:149
      */aerial.nvim/lua/aerial/window.lua:335
      */aerial.nvim/lua/aerial/window.lua:373
      */aerial.nvim/lua/aerial/init.lua:304
      */aerial.nvim/lua/aerial/command.lua:8

@github-actions github-actions bot requested a review from stevearc March 30, 2025 10:45
Copy link
Copy Markdown
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you just copy-pasting this same "fix" across a bunch of different repos? You didn't even check if CI passes.

@phanen phanen force-pushed the fix/deprecated-nightly branch from 082bdc7 to cfdf9e4 Compare March 31, 2025 04:37
@github-actions github-actions bot requested a review from stevearc March 31, 2025 04:37
@phanen
Copy link
Copy Markdown
Contributor Author

phanen commented Mar 31, 2025

Yeah, I first did this in fzf-lua. But I think this is caused by my custom conform formatter (which replace vim.fn to fn for me...

@phanen phanen force-pushed the fix/deprecated-nightly branch 3 times, most recently from bdfbc15 to d652bb3 Compare March 31, 2025 05:05
@mehalter
Copy link
Copy Markdown
Contributor

@phanen this might need to be rebased on master for the tests to pass. They don't look like they are coming from the specific changes you made.

@phanen phanen force-pushed the fix/deprecated-nightly branch from d652bb3 to 20e7dc6 Compare April 11, 2025 01:14
@phanen
Copy link
Copy Markdown
Contributor Author

phanen commented Apr 11, 2025

Sorry. Clearly I haven't developed a good habit yet. I rebase in conform.nvim but forget about this one...

@stevearc
Copy link
Copy Markdown
Owner

stevearc commented Jun 1, 2025

Looks good, thanks!

@stevearc stevearc merged commit 95825c9 into stevearc:master Jun 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants