fix(telescope): correct highlight offset computation (#414)#465
Merged
stevearc merged 1 commit intostevearc:masterfrom Jun 4, 2025
Merged
fix(telescope): correct highlight offset computation (#414)#465stevearc merged 1 commit intostevearc:masterfrom
stevearc merged 1 commit intostevearc:masterfrom
Conversation
Also enable highlights when `show_columns` is set to "symbols", since icons are displayed in that mode.
Owner
|
LGTM thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #414: highlights sometimes off by 1 in Telescope extension
This PR fixes incorrect offset computation for Tree-sitter highlights in the Telescope extension, which could cause them to appear shifted by one (or more) character.
Root Cause
The issue tries to compute the highlight offset before calling
displayer(). This approach is error-prone due to the presence of multibyte characters, single-byte characters, and potential line truncation, which makes it difficult to reliably calculate visual alignment.Solution
The fix changes the order of operations: it now calls
displayer()first to get the final rendered string, then calculates the highlight offset by searching for the start position of the text to highlight within that string.Additional Fix
The issue also noted that no highlights were applied when
show_columnswas set to "symbols". This PR enables highlights in that mode as well, since icons are displayed (and usually highlighted).