fix(c): remove buggy query pattern #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported bug of missing functions (stevearc#413) is caused by this query pattern: ``` ((declaration) @root @start . (function_definition) @symbol @EnD (#set! "kind" "Function")) ``` Removing the pattern fixes the bug and causes no regressions in tests. The pattern was introduced in stevearc@9135045 but it is not clear what its purpose is: all functions should be matched by the simple `(function_definition)` query immediately after it. The example from stevearc#413 and a few additional tests from tree-sitter-c's test corpus were added. Closes stevearc#413 Signed-off-by: Robert Muir <[email protected]>
Owner
|
The tests should have 100% coverage of the treesitter queries, so you can do pretty much whatever with the queries as long as the tests still pass. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported bug of missing functions (#413) is caused by this query pattern:
Removing the pattern fixes the bug and causes no regressions in tests. The pattern was introduced in 9135045 but it is not clear what its purpose is: all functions should be matched by the simple
(function_definition)query immediately after it.The example from #413 and a few additional tests from tree-sitter-c's test corpus were added.
Closes #413
Note: if by any chance you happen to remember what this pattern was trying to accomplish, I can look to address/test for it.