improve error message for unknown formatters #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This change LGTM. Did you want me to merge or did you want to try to change the highlighting? |
ro0gr
changed the title
Contributor
Author
|
Thanks. Yeah, I'll give a try to highlighting improvements. |
- use `error` instead of `unavailable` message type in case of initialization error - highlight with error color
ro0gr
force-pushed
the
unknown-formatter-message
branch
from
88255aa to
ab08da9
Compare
ro0gr
changed the title
Contributor
Author
|
It's ready for review now |
Owner
|
LGTM thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to solve the #582.
I'm not really sure if it makes the feedback noticeably better. But I think with this kind of message I might have noticed my configuration issue earlier.
I'd say it's still missing highlighting the
unavailablekeyword with an error color, cause this kind of error is probably caused by the misconfiguration on the user side, and it makes sense to make it as clear as possible. WDYT?