feat: add support for trunk #848
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Jan 17, 2026
lua/conform/formatters/trunk.lua
Outdated
Comment on lines
12
to
14
| cwd = util.root_file({ | ||
| ".trunk/trunk.yaml", | ||
| }), |
Owner
There was a problem hiding this comment.
I believe this will cause the cwd to evaluate to the .trunk directory, which might cause some problems. Is there any issue with just using the .trunk directory itself as the root file?
Contributor
Author
There was a problem hiding this comment.
Good point, I did further testing and actually realized that there was no need for conform to change working directory. I guess trunk has its own internal logic resolving the config.
Owner
|
LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Trunk meta formatter.
Closes #849