fix(border): default to nil to support winborder#643
Merged
stevearc merged 2 commits intostevearc:masterfrom Oct 15, 2025
Merged
fix(border): default to nil to support winborder#643stevearc merged 2 commits intostevearc:masterfrom
stevearc merged 2 commits intostevearc:masterfrom
Conversation
Owner
|
Thanks for the PR! |
itsjef
pushed a commit
to itsjef/dotfiles
that referenced
this pull request
Oct 17, 2025
changed after stevearc/oil.nvim#643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: winborder is not respected because border is hardcoded to
"rounded".Solution: default to
nilwhich will usewinborderif set by the user.Minor drawback:
winborderwas added in 0.11, and for users on a version less than this which was just using a default options, they now need to set it. I feel like this is reasonable though, and not assume which border the users want