Merged
Conversation
seblyng
changed the title
g~ over ~g~ over ~
Contributor
Author
|
Hmm okay, the maparg thing didn't seem to work as I wanted, so I will revert that. Hope you will consider the |
seblyng
changed the title
g~ over ~g~ over ~
Owner
|
Yeah, you know this really was an unfortunate choice and we should fix it. I don't think this will be a disruptive change for most people, and it's quite easy to add the old keybinding if people miss it, so I don't think I'll even mark this as a breaking change. Thanks for making the push for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening a PR to see if you are open to this. This will essentially be a breaking change, but I have seen a couple of issues around this, and also that you have regretted the decision to use
~as a mapping.Specifically for me, it was kind of annoying that<C-l>and<C-h>was mapped by default since I have those mapped to<C-w>land<C-w>hwhich I also would say are quite regular default mappingsLet me know what you think about this! Hope you can consider!