fix: set diagnostic code in on_result_diagnostics#430
Merged
stevearc merged 1 commit intostevearc:masterfrom Jul 1, 2025
franco-ruggeri:fix/issue-429
Merged
fix: set diagnostic code in on_result_diagnostics#430stevearc merged 1 commit intostevearc:masterfrom franco-ruggeri:fix/issue-429
stevearc merged 1 commit intostevearc:masterfrom
franco-ruggeri:fix/issue-429
Conversation
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #429.
This PR sets the diagnostic code on result diagnostic items sent by the
on_result_diagnosticscomponent. Please see #429 for details and for a minimal setup.Before
After
Note the error code
(arg-type).