feature(template/just): ✨ respect justfile modules#481
Merged
stevearc merged 1 commit intostevearc:masterfrom Dec 27, 2025
Merged
feature(template/just): ✨ respect justfile modules#481stevearc merged 1 commit intostevearc:masterfrom
stevearc merged 1 commit intostevearc:masterfrom
Conversation
Owner
|
This looks fine to me. To solve the issue of only finding a single justfile, you could look into passing a specific search directory using the capability added in #480. Thanks for the PR! |
Owner
|
I think I've managed to get the behavior that you're looking for in 4acd767 |
Contributor
Author
|
Ah ty <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://just.systems/man/en/modules1190.html
justdoes support modules. This PR makesjusttemplate provider traverse through modules and include their recipes.However, this PR is not done imo. If the parent
justfileis read, all of its children should/must be ignored (I haven't implemented this). Current behavior simply gets the nearestjustfileinstead of the rootjustfile, and template provider doesn't provide a way to manage global state to store something like ajustfileregistry.Given this tree:
Currently (with this PR), if
PWDis/, things work;overseershould showjust foo::bar. However, whenPWDis/and user navigates deeper (egfooorbaz) throughneo-tree(or similar plugins),/justfileisn't read; instead,/crates/foo/justfileis. This might be awkward to run tasks as it literally defeats the whole point of modules...I'm looking for a way to deal with this.