Skip to content

Conversation

@emmanueltouzery
Copy link
Contributor

for instance "yarn" which is a shortcut for "yarn install"

this is meant to restore the following line from the overseer1 npm adapter, which seems to have been lost in the 2.0 migration:
https://github.com/emmanueltouzery/overseer.nvim/blob/mine/lua/overseer/template/npm.lua#L138

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If yarn is just an alias for yarn install, wouldn't it be better to just use yarn install especially since it's disambiguated with all of the other yarn ... subcommands?

@emmanueltouzery
Copy link
Contributor Author

Maybe yes, and I don't know about npm by heart, but I wanted in the end to reproduce the behaviour from 1.x, which worked great for me. Happy to add the install flag instead of "" 👍

@stevearc
Copy link
Owner

Yeah, I think that would be the best solution for now. If you discover some incompatibility later that this would significantly streamline we can reconsider then

@stevearc stevearc closed this Jan 11, 2026
@emmanueltouzery
Copy link
Contributor Author

aha, you mean that i would make manually on my end a new job with "install"? because what i meant was to update this PR to add a job with "install" instead of being parameterless.

@stevearc
Copy link
Owner

Ah, sorry I'm going through PRs while very distracted. Adding it as an install subcommand make sense and should also play nicer with npm and pnpm

yarn install, npm install and so on.
@emmanueltouzery
Copy link
Contributor Author

force pushed the PR to add a install subcommand instead.

@stevearc
Copy link
Owner

Great, thanks!

@stevearc stevearc merged commit 3b4a118 into stevearc:master Jan 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants