Convert Google Prettify.js Links to CDN Links#116
Open
spreadred wants to merge 4 commits intosteveathon:2.0-devfrom
Open
Convert Google Prettify.js Links to CDN Links#116spreadred wants to merge 4 commits intosteveathon:2.0-devfrom
spreadred wants to merge 4 commits intosteveathon:2.0-devfrom
Conversation
Convert Google code-prettify links to use CDN and the new preferred method of loading: run_prettify.js which no longer requires separate includes of prettify.css
codewithtyler
left a comment
codewithtyler
left a comment
There was a problem hiding this comment.
Is this working without prettify.css?
Author
|
Yes. Here a link to a jsfiddle which simply includes |
Added instructions on how to properly initialize multiple editors on the same page. Proper initialization and usage resolves steveathon#117 steveathon#110 steveathon#31
Added Multiple Editors Instructions
Author
|
Looks like I messed up my PR. The only intended commit for this PR is the first commit on March 14 relating to the addition of the CDN links in the examples. |
Owner
|
@kaptainkommie did you want to cancel and re-open this PR with the cherry picked changes? Or go ahead with it as it is? |
|
According to repo info rawgit.com was turned off October 2019. It's possible to use this CDN now https://cdn.jsdelivr.net/gh/google/code-prettify@master/loader/run_prettify.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert Google code-prettify links to use CDN and the new preferred
method of loading: run_prettify.js which no longer requires separate
includes of prettify.css
Addresses issue #115