Conversation
|
This PR seems to contain commits from #992. Can you disentangle this and fix the conflict? Then we can merge either of these PRs first and the other afterwards. |
|
ok sorry, let’s work on the previous PR, ad because this is such a small correction after we would sort the previous commit i would add the new code. so you can close this one and we will handle it later:) |
|
@tzukpolinsky Do you have time to rebase and clean up this second part of your original PR? |
|
No, i forgot but i can do it tomorrow if you would like me to |
This is up to you. I am not getting paid for this, and you are not getting paid for this :-) If you have the time and still want to have this contribution of yours merged, I would appreciate and review and test this. Otherwise, I am also fine if you do not want to continue working on this. In this case, just let me know and I can close the PR (without merging). |
|
thank you for your consideration:) |
…windows # Conflicts: # components/pango_geometry/src/geometry_obj.cpp # components/pango_glgeometry/src/glgeometry.cpp
|
@tzukpolinsky Is this something you could still work on? Or should I just close this? If you can rebase this and clean it up a bit, and give me an example of how this should work, I could probably pick up your work from there. |
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
|
I thought i fized it in the last commit didnt I? |
The CI fails. Also some of the commits reference changes from your other PR. |
|
So do you want me to close the pull request or should I? |
Just close it, if you do not want to continue with this. |
3 participants
This is the multiple windows, detached from the cmake changes for windows. im not sure if it would work as a shared lib, also i cant think of reason it wont:)
This allows to open several different pangolin windows by changing the type of registration for the window. i hope it would work out of the box. sry i can test it other then looking at the code