Obsolete: Cronet proxy support from GreatFire Envoy #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenmcdonald
commented
Jun 4, 2025
| @@ -669,6 +683,29 @@ TEST_P(UrlRequestTest, SimpleGet) { | |||
| ExpectResponseInfoEquals(expected_response_info, *callback->response_info()); | |||
| } | |||
|
|
|||
| TEST_P(UrlRequestTest, ProxyGet) { | |||
There was a problem hiding this comment.
I could use some advice on improving this test. The test server doesn't seem to be set up for the 2 step process of "CONNECT" and then request. I'm not quite sure what the best way is to fully test this code
stevenmcdonald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've heard Google is working on proxy support in Cronet on their own... I'll leave this here for now for reference
--
This adds support to Cronet for using an HTTP(S) or SOCKS proxy server. In the current implementation, it's an EngineBuilder option to set a proxy for the Engine
This is maybe related to: https://issues.chromium.org/issues/40386536
This functionality is used in GreatFire's Envoy: https://github.com/greatfire/envoy