Cronet DNS, DoH overrides to enable ECH from GreatFire Envoy #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenmcdonald
changed the title
stevenmcdonald
changed the title
stevenmcdonald
commented
Jul 10, 2025
| // Envoy does this | ||
| overrides.secure_dns_mode = net::SecureDnsMode::kSecure; | ||
|
|
||
| // This is a little silly, Dict -> JSON -> Dict |
There was a problem hiding this comment.
I was having type issues here, they are IIRC a base::DictValue and a base::Dict::Value which seem to not be exactly compatible. There's probably a more straightforward way to do the needed conversion, but this is what I did to get it working for now
stevenmcdonald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who and why?
See the notes on: #5
DNS / DoH options
The goal of this feature was to enable ECH. To do that, we needed enable and configure the StandaloneResolver, and apply it to the context builder. We only need to override the
dns_over_https_configfor our purposes, that's what this patch does, though we could expose more of thenet::DnsConfigOverridesoptions if that would be usefulSimilar questions/comments to #5:
net::DnsConfigOverridessettable?