Improve configuration cache compatibility (#39)#51
Open
Vampire wants to merge 1 commit intostevesaliman:masterfrom
Open
Improve configuration cache compatibility (#39)#51Vampire wants to merge 1 commit intostevesaliman:masterfrom
Vampire wants to merge 1 commit intostevesaliman:masterfrom
Conversation
Contributor
Author
|
Ah, reverting the commit f8ce69d makes the tests run again and they still work with my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major improvement regarding issue #39, even though it does not fully fix it.
But at least with this change not each and every environment variable and system property becomes a CC input and thus rendering CC totally useless and just wasting time.
With this PR only the respectively prefixed variables and properties become CC inputs.
The used methods make the plugin requiring at least Gradle 7.5.
This could of course be guarded by some version check, depending on which Gradle version you want to maintain compatibility with.
Unfortunately, there is no functional test, that tests against actual Gradle version that should be lowest supported, and the documented compatibility of 2.1 is already wrong in 1.5.3 (#50).
So if older compatibility is wanted, a switch can be inserted (or mutliple variants published, but that is probably overkill here) to only use the new methods in new Gradle versions and keep the old logic in older ones.
The changes here should work fine as far as I have quickly tested in a play project.
But I have no idea whether the tests still work, because even in
masterI do not get the tests to run properly, they always fail with "Failed to set ORG_GRADLE_PROJECT_environmentProperty" no matter which Java version I tried to run them. (8, 11, 17, 21, ...) and there is no visible CI set up so far.