fix: verify types.custom persisted before writing sentinel#2694
Open
Henry-E wants to merge 1 commit intosteveyegge:mainfrom
Open
fix: verify types.custom persisted before writing sentinel#2694Henry-E wants to merge 1 commit intosteveyegge:mainfrom
Henry-E wants to merge 1 commit intosteveyegge:mainfrom
Conversation
EnsureCustomTypes() trusted the sentinel file without verifying the database actually had types.custom configured. If bd config set exited 0 but failed to write (wrong DB, redirect mismatch, server down), the sentinel cached a lie and all future calls skipped re-configuration. This caused gt sling to fail with "invalid issue type: agent" on rigs where the database was recreated but the sentinel file survived. Fix: after bd config set, verify with bd config get that types.custom contains "agent" before writing the sentinel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureCustomTypes()trusted the sentinel file without verifying the database actually hadtypes.customconfiguredbd config setexited 0 but silently failed to write (wrong DB, redirect mismatch, server restart), the sentinel cached a lie — all future calls skipped re-configurationgt slingto fail withinvalid issue type: agenton rigs where the database was recreated but the sentinel survivedbd config set, runbd config get types.customto verify the value containsagentbefore writing the sentinelFixes #2637
Test plan
TestEnsureCustomTypes_VerifyPersistence— verifies sentinel is NOT written whenbd config getreturns emptyconfig get types.custom)types.customand got fixed🤖 Generated with Claude Code