Reduce code #249
Merged
Reduce code #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces lines of code to maintain. Thats good
Using apt instead saves a lot of effort and should be easier to upgrade / configure
Small changes to fix linting errors
Collaborator
|
@khalford the CI is picking up the path twice: |
Install the collections for the workflow so when we run the linter it has access to the prometheus role.
DavidFair
approved these changes
Oct 8, 2025
dev-0pz
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use apt and ansible roles to install prometheus services. Also change prometheus targets to localhost only as the whole app runs on one VM