Skip to content

Conversation

@khalford
Copy link
Member

Minor changes to the deployment.

  • Fixes a typo with the SSL role module task name
  • Removes unused count variable from container name
  • Rotate secrets
  • Add terraform variable to use separate clouds.yaml entries for authenticating against multiple clouds

Rotating tokens as they have expired
This was missed in a previous PR. It was caused by a find and replace.
@khalford khalford requested review from a team, DavidFair and jose-caballero October 22, 2025 12:13
@jose-caballero
Copy link
Contributor

I have a question:

On the new variable for clouds.yaml, why is it called "openstack"? Is that required by terraform? I find the name "openstack" to be a little bit ambiguous, can be interpreted in many different ways, so I would suggest something more clear unless we are forced to used it.

@khalford
Copy link
Member Author

I have a question:

On the new variable for clouds.yaml, why is it called "openstack"? Is that required by terraform? I find the name "openstack" to be a little bit ambiguous, can be interpreted in many different ways, so I would suggest something more clear unless we are forced to used it.

I understand it is weird. I was just using whatever name the clouds.yaml file suggests to use. But actually I remembered incorrectly.

# This is a clouds.yaml file, which can be used by OpenStack tools as a source
# of configuration on how to connect to a cloud. If this is your only cloud,
# just put this file in ~/.config/openstack/clouds.yaml and tools like
# python-openstackclient will just work with no further config. (You will need
# to add your password to the auth section)
# If you have more than one cloud account, add the cloud entry to the clouds
# section of your existing file and you can refer to them by name with
# OS_CLOUD=openstack or --os-cloud=openstack
clouds:

I will rename it from openstack -> cloud

@jose-caballero
Copy link
Contributor

Does that mean that Terraform is not capable of getting the cloud name from the title of each section in clouds.yaml, and that's why you need to add another label to the file?

@jose-caballero
Copy link
Contributor

I can reply to my last question. Apparently not, from what Gemini just told me :)

@khalford khalford force-pushed the minor_changes branch 2 times, most recently from 5ebe90d to f162c9e Compare October 22, 2025 12:50
jose-caballero
jose-caballero previously approved these changes Oct 22, 2025
When deploying in different clouds we need separate credentials. I've added a variable called cloud which will tell terraform which entry in clouds.yaml to use for authentication.
We are only deploying one container. This was missed in a previous PR and needs to be removed.
@jose-caballero jose-caballero merged commit 789ffcb into master Oct 23, 2025
5 checks passed
@khalford khalford deleted the minor_changes branch October 23, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants