Merged
Conversation
alinelena
approved these changes
Jan 30, 2025
oerc0122
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think some changes introduced in #350 resulted in various new documentation warnings being raised, possibly (but I don't think entirely) related to the version bump for sphinx, as I'm not sure why I didn't see them sooner.
This resolves two types of warning e.g.:
WARNING: py:class reference target not found: Dynamics [ref.class], requiring changes/updates to the nitpick ignore, as we have in the pastWARNING: duplicate object description of janus_core.calculations.phonons.Phonons.write_force_constants, other instance in apidoc/janus_core, use :no-index: for one of them. In most cases, these are class methods, which we already document slightly inconsistently, so for now I've just removed them. Other solutions are probably available (e.g. the suggestion from the warning)