Merged
Conversation
oerc0122
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #664
The SVG error in the publish action isn't actually an error with the SVG reader/display, but because the file is missing, due to errors raised by the CLI commands.
I missed this as I had the previous output files locally still, as they live in source, not build, so the docs built successfully until I deleted these.
The first of the errors is the deprecation of
modelviacalc_kwargs.However, there also seems to be an issue optimising the geometry of the structures in our NEBs example.
I've removed this for now, since we don't want to block releases, but it does seem to make the NEBs considerably worse, so hopefully we can find a fix later.