New CSS selectors for mic/camera buttons#4
Open
vljosa-vivodyne wants to merge 1 commit intostffffn:masterfrom
Open
New CSS selectors for mic/camera buttons#4vljosa-vivodyne wants to merge 1 commit intostffffn:masterfrom
vljosa-vivodyne wants to merge 1 commit intostffffn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome seems to no longer have the keyboard shortcut in the
aria-labelof the microphone and camera buttons, so selectors likearia-label*="+ d"no longer worked.Update the selectors to match the new labels, e.g.,
aria-label="Turn off microphone".This will break for users with non-English localization in Chrome. The "Turn off microphone (⌘ + d)" text is now in a div that is a sibling to the button, so matching on that would be a larger change that I'm not comfortable making. Since the extension was broken already, this PR is an improvement even if it does not fix it for all users.