Start adding types and cleaning up classes.py #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunngitter
commented
Feb 23, 2025
also start cleaning up stashapp.py and stashbox.py a little bit added a `get_logger` method to log.py which can be used instead of `import stashapi.log as log`
there were a couple of functions here that I really didn't know what to do with because I don't see any example uses in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with my last PR I started out just wanting to add some types, but the scope very quickly exploded. This is going to be a huge change and will need pretty thorough testing.
Changes:
get_loggermethod to log.py which can be used instead ofimport stashapi.log as logTotally untested so far
Todo: