remove unnecessary gate#439
Merged
leastbad merged 2 commits intostimulusreflex:masterfrom Feb 4, 2021
Merged
Conversation
Contributor
Author
|
Note that the file view on this PR looks intimidating, but it's literally just removing lines 494-496, 604. The changeset is the result of the indentation formatting moving everything two spaces to the left. |
hopsoft
approved these changes
Feb 4, 2021
Contributor
hopsoft
left a comment
hopsoft
left a comment
There was a problem hiding this comment.
This should be safe considering that SR is typically initialized in app/javascript/controllers/index.js or somewhere similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
"Enhancement"
Description
Back in #45 (aka callbacks) we introduced a gate around the bottom-half of the main
stimulus_reflex.jsto make sure it was only executed once. The thing is, I cannot for the life of me see what purpose this serves. Presumably, with or without Turbolinks, this code is only going to be executed once per page - or else theconst initializeimmediately above it would already be complaining loudly, right?This PR just removes the gate. There could be a very good reason to keep it! I just don't know what we were guarding against.
Why should this be added
Code clarity
Checklist