fix(package.json): Add 'types/*' to package exports#1115
Open
jeffberry wants to merge 1 commit intostitchesjs:canaryfrom
Open
fix(package.json): Add 'types/*' to package exports#1115jeffberry wants to merge 1 commit intostitchesjs:canaryfrom
jeffberry wants to merge 1 commit intostitchesjs:canaryfrom
Conversation
|
I confirm this need on my side to pass a lib in ESM and pass the moduleResolution in Node16 |
|
Please accept this PR |
|
@peduarte who should we @ to get this looked at? Thank you again for your time! Love the library. |
3 tasks
Contributor
|
This actually looks really good. If I can get some access, I could merge this and put it into a release. |
Contributor
Contributor
|
@hadihallak @StephenHaney could you please merge this in and put it into a canary release or give @jonathantneal access do do so? This doesn't seem like much effort and would unblock usage of stitches with TypeScript's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue that we are experiencing when setting
moduleResolutionin our tsconfig toNodeNext. When this is enabled, the module resolution will only allow importing from paths that are defined within theexportsconfig. Because onlytypes/index.d.tsis available for import, it is causing these kinds of embedded imports to fail:I think the alternative would be to ensure that all types are exported from the
types/index.d.tsfile.