Skip to content

Fixed package.json#exports.types #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andarist wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Fixed package.json#exports.types #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"name": "@stitches/core",
"version": "1.3.1-1",
"description": "The modern CSS-in-JS library",
"type": "module",
Copy link
Author

@Andarist Andarist Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that you actually needed this. You still provide exports.import after all. Having those packages as modules changes how .js (and this .d.ts) files are treated and supporting types with this setup would be much more complicated. So I think that there is no harm if we just remove this from here to make types work.

"main": "dist/index.cjs",
"module": "dist/index.mjs",
"types": "types/index.d.ts",
Expand All @@ -17,9 +16,9 @@
"unpkg": "dist/index.global.js",
"exports": {
".": {
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.mjs",
"types": "./types/index.d.ts"
"import": "./dist/index.mjs"
},
"./global": "./dist/index.global.js"
},
Expand Down
5 changes: 2 additions & 3 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"name": "@stitches/react",
"version": "1.3.1-1",
"description": "The modern CSS-in-JS library",
"type": "module",
"main": "dist/index.cjs",
"module": "dist/index.mjs",
"types": "types/index.d.ts",
Expand All @@ -17,9 +16,9 @@
"unpkg": "dist/index.global.js",
"exports": {
".": {
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.mjs",
"types": "./types/index.d.ts"
"import": "./dist/index.mjs"
},
"./global": "./dist/index.global.js"
},
Expand Down
5 changes: 2 additions & 3 deletions packages/stringify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,16 @@
"name": "@stitches/stringify",
"version": "1.3.1-1",
"description": "Converts an object into CSS",
"type": "module",
"main": "dist/index.cjs",
"module": "dist/index.mjs",
"typings": "types/index.d.ts",
"jsdelivr": "dist/index.global.js",
"unpkg": "dist/index.global.js",
"exports": {
".": {
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.mjs",
"types": "./types/index.d.ts"
"import": "./dist/index.mjs"
},
"./global": "./dist/index.global.js"
},
Expand Down