chore: code review feedback.

Author: peterhuene

examples/task-list-all.rs

@@ -32,7 +32,7 @@ async fn list_all_tasks(client: &Client) -> Result<()> {
     loop {
         let response = client
             .list_tasks(Some(&ListTasksParams {
-                view: View::Full,
+                view: Some(View::Full),
                 page_token: last_token,
                 ..Default::default()
             }))

src/v1/client.rs

@@ -169,7 +169,7 @@ impl Client {
             None => "tasks".to_string(),
         };
 
-        match params.map(|p| p.view).unwrap_or_default() {
+        match params.and_then(|p| p.view).unwrap_or_default() {
             View::Minimal => {
                 let results = self.get::<ListTasks<MinimalTask>>(url).await?;
 

src/v1/types/requests.rs

@@ -61,9 +61,9 @@ pub struct ListTasksParams {
     /// If empty, no task tags filtering is done.
     #[cfg_attr(
         feature = "serde",
-        serde(rename = "tag_key", default, skip_serializing_if = "Vec::is_empty")
+        serde(rename = "tag_key", default, skip_serializing_if = "Option::is_none")
     )]
-    pub tag_keys: Vec<String>,
+    pub tag_keys: Option<Vec<String>>,
     /// The filter for task tag values.
     ///
     /// This is zipped with `tag_keys`.
@@ -73,9 +73,9 @@ pub struct ListTasksParams {
     /// It is an error if more values are supplied than keys.
     #[cfg_attr(
         feature = "serde",
-        serde(rename = "tag_value", default, skip_serializing_if = "Vec::is_empty")
+        serde(rename = "tag_value", default, skip_serializing_if = "Option::is_none")
     )]
-    pub tag_values: Vec<String>,
+    pub tag_values: Option<Vec<String>>,
     /// The number of tasks to return in one page.
     ///
     /// Must be less than 2048. Defaults to 256.
@@ -90,8 +90,8 @@ pub struct ListTasksParams {
     #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))]
     pub page_token: Option<String>,
     /// The view of the returned task(s).
-    #[cfg_attr(feature = "serde", serde(default))]
-    pub view: View,
+    #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))]
+    pub view: Option<View>,
 }
 
 /// Represents the request body of the `CreateTask` endpoint.

src/v1/types/responses/service_info.rs

@@ -99,6 +99,16 @@ pub struct ServiceInfo {
     /// service.
     #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))]
     storage: Option<Vec<String>>,
+
+    /// Lists all resource.backend_parameters keys supported by the service.
+    #[cfg_attr(
+        feature = "serde",
+        serde(
+            rename = "tesResources_backend_parameters",
+            skip_serializing_if = "Option::is_none"
+        )
+    )]
+    backend_parameters: Option<Vec<String>>,
 }
 
 impl ServiceInfo {
@@ -263,12 +273,13 @@ mod tests {
                 String::from("file:///path/to/local/funnel-storage"),
                 String::from("s3://ohsu-compbio-funnel/storage"),
             ]),
+            backend_parameters: Some(vec!["foo".into(), "bar".into()]),
         };
 
         let serialized = serde_json::to_string(&info).unwrap();
         assert_eq!(
             serialized,
-            r#"{"id":"org.ga4gh.myservice","name":"My Server","type":{"group":"org.ga4gh","artifact":"tes","version":"1.0.0"},"description":"A description","organization":{"name":"My Organization","url":"https://example.com/"},"contactUrl":"mailto:foo@bar.com","documentationUrl":"https://docs.myservice.example.com/","createdAt":"2024-09-07T20:27:35.345673Z","updatedAt":"2024-09-07T20:27:35.345673Z","environment":"test","version":"1.5.0","storage":["file:///path/to/local/funnel-storage","s3://ohsu-compbio-funnel/storage"]}"#
+            r#"{"id":"org.ga4gh.myservice","name":"My Server","type":{"group":"org.ga4gh","artifact":"tes","version":"1.0.0"},"description":"A description","organization":{"name":"My Organization","url":"https://example.com/"},"contactUrl":"mailto:foo@bar.com","documentationUrl":"https://docs.myservice.example.com/","createdAt":"2024-09-07T20:27:35.345673Z","updatedAt":"2024-09-07T20:27:35.345673Z","environment":"test","version":"1.5.0","storage":["file:///path/to/local/funnel-storage","s3://ohsu-compbio-funnel/storage"],"tesResources_backend_parameters":["foo","bar"]}"#
         );
 
         let deserialized: ServiceInfo = serde_json::from_str(&serialized).unwrap();

src/v1/types/responses/service_info/builder.rs

@@ -77,6 +77,9 @@ pub struct Builder {
     ///
     /// This does not necessarily have to list _all_ storage locations.
     storage: Option<Vec<String>>,
+
+    /// Lists all resource.backend_parameters keys supported by the service.
+    backend_parameters: Option<Vec<String>>,
 }
 
 impl Builder {
@@ -215,6 +218,17 @@ impl Builder {
         self
     }
 
+    /// Sets all resource.backend_parameters keys supported by the service.
+    ///
+    /// # Notes
+    ///
+    /// This silently overrides any previously set supported backend parameters
+    /// for the service.
+    pub fn backend_parameters(mut self, value: impl Into<Vec<String>>) -> Self {
+        self.backend_parameters = Some(value.into());
+        self
+    }
+
     /// Consumes `self` and attempts to builde a [`ServiceInfo`].
     pub fn try_build(self) -> Result<ServiceInfo> {
         let id = self.id.ok_or(Error::Missing("id"))?;
@@ -249,6 +263,7 @@ impl Builder {
             environment: self.environment,
             version,
             storage: self.storage,
+            backend_parameters: self.backend_parameters,
         })
     }
 }