Skip to content

GDC WSI support.#2644

Merged
aacic merged 1 commit intomasterfrom
wsiviewer
Jan 27, 2025
Merged

GDC WSI support.#2644
aacic merged 1 commit intomasterfrom
wsiviewer

Conversation

@aacic
Copy link
Collaborator

@aacic aacic commented Jan 23, 2025

Description

The purpose of this PR is to enable testing of TileServer integration on the pp-irt. In prod it should work the way it works now. Once testing and fixes are performed the redis integration will be enabled in prod.

To test it locally:

Add to server config:

{
  "redis" : {
    "url": "redis://localhost:6379",
    "secret": "generate_some_secret"
  },
  ...
  
  "tileServerURL": "http://localhost:5000",
  "tileServerMount": "/path/to/tp"
  }

Install redis:

  brew install redis
  brew services start redis

Test it works:

redis-cli
PING

If Redis is running, it will return: PONG

Set up TileServer like explained here:

TissueImageAnalytics/tiatoolbox#897

Generate a fsspec JSON file like explained inside of the PR.

Change tileserver.py code to:


from flask_cors import CORS
from tiatoolbox.visualization import TileServer

# Initialize and run the TileServer
tile_server = TileServer(
    title="Tiatoolbox TileServer",
    layers={},
)
CORS(tile_server, send_wildcard=True)


tile_server.run(host="127.0.0.1", port=5000)

Start the TileServer like:

python3 tileserver.py

Place JSON file inside of:

/path/to/tp/hg38/gdc/wsimages/73c69d24-6f9e-44e2-bfe5-a608d4cf5c27/73c69d24-6f9e-44e2-bfe5-a608d4cf5c27_fsspec.json

Check out the corresponding PR from sjpp repo.

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@aacic aacic force-pushed the wsiviewer branch 3 times, most recently from b657d00 to ad61c52 Compare January 23, 2025 19:19
@aacic aacic marked this pull request as ready for review January 23, 2025 19:26
@aacic aacic requested a review from siosonel January 23, 2025 19:33
siosonel
siosonel previously approved these changes Jan 25, 2025
Copy link
Member

@siosonel siosonel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works after setting up redis, tiileserver, and other dependencies. Super fast zooming and panning.

@aacic aacic force-pushed the wsiviewer branch 2 times, most recently from 3aeb5f4 to 910618f Compare January 27, 2025 17:37
@aacic aacic merged commit 73f5d96 into master Jan 27, 2025
3 checks passed
@aacic aacic deleted the wsiviewer branch January 27, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants