Conversation
b657d00 to
ad61c52
Compare
siosonel
previously approved these changes
Jan 25, 2025
Member
siosonel
left a comment
There was a problem hiding this comment.
It works after setting up redis, tiileserver, and other dependencies. Super fast zooming and panning.
3aeb5f4 to
910618f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to enable testing of TileServer integration on the pp-irt. In prod it should work the way it works now. Once testing and fixes are performed the redis integration will be enabled in prod.
To test it locally:
Add to server config:
Install redis:
Test it works:
If Redis is running, it will return: PONG
Set up TileServer like explained here:
TissueImageAnalytics/tiatoolbox#897
Generate a fsspec JSON file like explained inside of the PR.
Change tileserver.py code to:
Start the TileServer like:
python3 tileserver.pyPlace JSON file inside of:
/path/to/tp/hg38/gdc/wsimages/73c69d24-6f9e-44e2-bfe5-a608d4cf5c27/73c69d24-6f9e-44e2-bfe5-a608d4cf5c27_fsspec.jsonCheck out the corresponding PR from sjpp repo.
Checklist
Check each task that has been performed or verified to be not applicable.