Skip to content

Termcollection summaryplot#4259

Draft
vivekavuthu wants to merge 1 commit intomasterfrom
termcollection_summaryplot
Draft

Termcollection summaryplot#4259
vivekavuthu wants to merge 1 commit intomasterfrom
termcollection_summaryplot

Conversation

@vivekavuthu
Copy link
Contributor

This pull request introduces improvements and refactoring to how term collections are defined and handled in the dataset, as well as minor enhancements to logging and helper management in the server initialization code. The most significant changes involve splitting the term collection type into distinct numeric and categorical variants, adding a new property for categorical collections, and improving retry logging for dataset initialization.

Refactoring and feature enhancements for term collections:

  • Split the TermCollection type in shared/types/src/dataset.ts into separate NumericTermCollection and CategoricalTermCollection types, allowing for more precise typing and future extensibility.
  • Added a categoryKeys property to CategoricalTermCollection, enabling explicit specification of which category attributes to use for categorical collections.
  • Updated the test dataset definition in server/dataset/termdb.test.ts to use the new categoryKeys property for categorical term collections.

Server initialization and logging improvements:

  • Enhanced retry logging in server/src/initGenomesDs.js to include the retry delay in seconds, making retry messages more informative for debugging.
  • Added the mayLog helper to the exported dsHelpers object in server/src/initGenomesDs.js for more flexible logging capabilities.

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: Added and/or passed unit and integration tests, or N/A
  • Todos: Commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A
  • Rust: Checked to see whether Rust needs to be re-compiled because of this PR, or N/A

@vivekavuthu vivekavuthu force-pushed the termcollection_summaryplot branch from 2dbcdaf to 2aa6e9e Compare March 2, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant