Skip to content

static type declarations added#4315

Merged
xzhou82 merged 1 commit intomasterfrom
profile_staticType
Mar 17, 2026
Merged

static type declarations added#4315
xzhou82 merged 1 commit intomasterfrom
profile_staticType

Conversation

@vivekavuthu
Copy link
Contributor

This pull request adds a new static property to both the ProfilePolar and profileBarchart classes to help identify their types. This will make it easier to distinguish between different plot types in the codebase.

Plot class enhancements:

  • Added a static type property with the value 'profilePolar' to the ProfilePolar class in polar.ts.
  • Added a static type property with the value 'profileBarchart' to the profileBarchart class in profileBarchart.ts.# Description

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: Added and/or passed unit and integration tests, or N/A
  • Todos: Commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A
  • Rust: Checked to see whether Rust needs to be re-compiled because of this PR, or N/A

@vivekavuthu vivekavuthu requested a review from xzhou82 March 17, 2026 18:36
@vivekavuthu vivekavuthu marked this pull request as ready for review March 17, 2026 18:43
Copilot AI review requested due to automatic review settings March 17, 2026 18:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing static type identifiers to the profile plot components so they can be reliably recognized (and so getCompInit() can wrap them without throwing).

Changes:

  • Added static type = 'profileBarchart' to profileBarchart
  • Added static type = 'profilePolar' to ProfilePolar

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
client/plots/profile/profileBarchart.ts Declares static type for the barchart profile plot component.
client/plots/profile/polar.ts Declares static type for the polar profile plot component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xzhou82 xzhou82 merged commit c4efd20 into master Mar 17, 2026
7 checks passed
@xzhou82 xzhou82 deleted the profile_staticType branch March 17, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants