Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing static type identifiers to the profile plot components so they can be reliably recognized (and so getCompInit() can wrap them without throwing).
Changes:
- Added
static type = 'profileBarchart'toprofileBarchart - Added
static type = 'profilePolar'toProfilePolar
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/plots/profile/profileBarchart.ts | Declares static type for the barchart profile plot component. |
| client/plots/profile/polar.ts | Declares static type for the polar profile plot component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xzhou82
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new static property to both the
ProfilePolarandprofileBarchartclasses to help identify their types. This will make it easier to distinguish between different plot types in the codebase.Plot class enhancements:
typeproperty with the value'profilePolar'to theProfilePolarclass inpolar.ts.typeproperty with the value'profileBarchart'to theprofileBarchartclass inprofileBarchart.ts.# DescriptionChecklist
Check each task that has been performed or verified to be not applicable.