isp_wrapper: few minor improvements & allow repeated start / stop #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 12, 2025 13:44
Include the Zephyr DCMIPP driver exported stm32_dcmipp.h header file in order to get weak functions prototypes. Signed-off-by: Alain Volmat <[email protected]>
Add an assert in the stm32_dcmipp_isp_init function to check the validity of the sensor parameter. This pointer is later on used by all ISP ops. Signed-off-by: Alain Volmat <[email protected]>
No specific processing is necessary currently as part of the stm32_dcmipp_isp_start function hence remove the assert(0) currently preventing stop of the isp. Signed-off-by: Alain Volmat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide few minor improvements such as assert and removal of duplicated prototypes as well as allow performing repeated start / stop of the camera pipeline.