Skip to content

Conversation

tlevora
Copy link
Contributor

@tlevora tlevora commented Dec 17, 2024

Description

Smoltcp updated to version 0.12.0. Examples fixed correspondingly.

TODO

  1. Update CHANGELOG.md

@datdenkikniet
Copy link
Contributor

Hi and thanks for the contribution!

Have you tested that all of this works as expected (i.e. ran the examples on some microcontroller)?

@datdenkikniet
Copy link
Contributor

datdenkikniet commented Dec 17, 2024

Additionally: if you would be so kind to add an entry to the changelog, and bump the version of stm32-eth to v0.8.0 (in separate commits, preferably in that order) we can get this shipped right out :)

@tlevora
Copy link
Contributor Author

tlevora commented Dec 17, 2024

Hi and thanks for the contribution!

Have you tested that all of this works as expected (i.e. ran the examples on some microcontroller)?

I've successfully executed arp and smoltcp-client examples on STM32F746.

@tlevora
Copy link
Contributor Author

tlevora commented Dec 17, 2024

Additionally: if you would be so kind to add an entry to the changelog, and bump the version of stm32-eth to v0.8.0 (in separate commits, preferably in that order) we can get this shipped right out :)

Sure, I could do that! Do you mean to bump the version + update changelog in a separate PR?

@datdenkikniet
Copy link
Contributor

datdenkikniet commented Dec 17, 2024

I've successfully executed arp and smoltcp-client examples on STM32F746.

Excellent, that sounds good enough for me.

Additionally: if you would be so kind to add an entry to the changelog, and bump the version of stm32-eth to v0.8.0 (in separate commits, preferably in that order) we can get this shipped right out :)

Sure, I could do that! Do you mean to bump the version + update changelog in a separate PR?

Great :) No, same PR is fine, just so long as they are separate commits, one for changelog, one for version bump. (I won't squash them, so we'll retain nice history on the master branch). Linking to the as-of-yet-nonexistent v0.8.0 tag in the changelog header is fine, I will add it ASAP.

@tlevora tlevora force-pushed the smoltcp-0.12.0-upgrade branch from 7d7d544 to 4b1cb72 Compare December 17, 2024 21:57
@datdenkikniet datdenkikniet merged commit f9811ec into stm32-rs:master Dec 17, 2024
57 checks passed
@datdenkikniet
Copy link
Contributor

Thanks again for your contribution :)

v0.8.0 is now available.

@tlevora
Copy link
Contributor Author

tlevora commented Dec 17, 2024

@datdenkikniet: Thank you for your help and very quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants