Skip to content

Allow create open-drain outputs with pull-up or pull-down #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holly-hacker wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow create open-drain outputs with pull-up or pull-down #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70f5ed7
Allow creating pull-up/pull-down open-drain outputs
holly-hacker Jan 24, 2026
33405e9
Update changelog
holly-hacker Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- impl embedded_hal_1::spi::SpiBus for SPI
- impl embedded_hal_1::digital traits for Pins
- Enable AF1 on GPIOE for pins [13, 14, 15] to support SPI communication
- Allow creating open-drain output pins with pull-up or pull-down

### Fixed

Expand Down
40 changes: 40 additions & 0 deletions src/gpio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,46 @@ macro_rules! gpio {
$PXi { _mode: PhantomData }
}

/// Configures the pin to operate as a pulled up open drain output pin
pub fn into_pullup_open_drain_output(
self, _cs: &CriticalSection
) -> $PXi<Output<OpenDrain>> {
let offset = 2 * $i;
unsafe {
let reg = &(*$GPIOX::ptr());
reg.pupdr.modify(|r, w| {
w.bits((r.bits() & !(0b11 << offset)) | (0b01 << offset))
});
reg.otyper.modify(|r, w| {
w.bits(r.bits() | (0b1 << $i))
});
reg.moder.modify(|r, w| {
w.bits((r.bits() & !(0b11 << offset)) | (0b01 << offset))
});
}
$PXi { _mode: PhantomData }
}

/// Configures the pin to operate as a pulled down open drain output pin
pub fn into_pulldown_open_drain_output(
self, _cs: &CriticalSection
) -> $PXi<Output<OpenDrain>> {
let offset = 2 * $i;
unsafe {
let reg = &(*$GPIOX::ptr());
reg.pupdr.modify(|r, w| {
w.bits((r.bits() & !(0b11 << offset)) | (0b10 << offset))
});
reg.otyper.modify(|r, w| {
w.bits(r.bits() | (0b1 << $i))
});
reg.moder.modify(|r, w| {
w.bits((r.bits() & !(0b11 << offset)) | (0b01 << offset))
});
}
$PXi { _mode: PhantomData }
}

/// Configures the pin to operate as an push pull output pin
pub fn into_push_pull_output(
self, _cs: &CriticalSection
Expand Down
Loading