Skip to content

Add support for UART4/5 #117

Add support for UART4/5

Add support for UART4/5 #117

Triggered via pull request March 30, 2025 11:42
@burrbullburrbull
synchronize #529
Status Success
Total duration 10s
Artifacts

changelog.yml

on: pull_request_target
Changelog check
5s
Changelog check
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
empty line after doc comment: src/rtc.rs#L28
warning: empty line after doc comment --> src/rtc.rs:28:1 | 28 | / /** 29 | | Real time clock 30 | | 31 | | A continuously running clock that counts seconds¹. It is part of the backup domain which means ... | 43 | | */ 44 | | | |_^ 45 | pub struct Rtc<CS = RtcClkLse> { | ------------------------------ the comment documents this struct | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it
empty line after doc comment: src/rcc.rs#L189
warning: empty line after doc comment --> src/rcc.rs:189:5 | 189 | / /// ``` 190 | | | |_^ 191 | #[inline(always)] 192 | pub fn freeze(self, acr: &mut ACR) -> Clocks { | -------------------------------------------- the comment documents this method | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it
empty line after doc comment: src/gpio.rs#L516
warning: empty line after doc comment --> src/gpio.rs:516:5 | 516 | / /** 517 | | Set the output of the pin regardless of its mode. 518 | | Primarily used to set the output value of the pin 519 | | before changing its mode to an output to avoid 520 | | a short spike of an incorrect value 521 | | */ 522 | | | |_^ 523 | #[inline(always)] 524 | fn _set_state(&mut self, state: PinState) { | ----------------------------------------- the comment documents this method | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default = help: if the empty line is unintentional remove it
the following explicit lifetimes could be elided: 'a: src/flash.rs#L66
warning: the following explicit lifetimes could be elided: 'a --> src/flash.rs:66:6 | 66 | impl<'a> FlashWriter<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 66 - impl<'a> FlashWriter<'a> { 66 + impl FlashWriter<'_> { |
operator precedence can trip the unwary: src/rtc.rs#L363
warning: operator precedence can trip the unwary --> src/rtc.rs:363:9 | 363 | self.regs.cnth().read().bits() << 16 | self.regs.cntl().read().bits() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.regs.cnth().read().bits() << 16) | self.regs.cntl().read().bits()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: src/i2c.rs#L285
warning: operator precedence can trip the unwary --> src/i2c.rs:285:35 | 285 | .write(|w| w.dr().set(addr << 1 | (u8::from(read)))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(addr << 1) | (u8::from(read))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: src/flash.rs#L248
warning: operator precedence can trip the unwary --> src/flash.rs:248:30 | 248 | let hword: u16 = (data[idx] as u16) | (data[idx + 1] as u16) << 8; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(data[idx] as u16) | ((data[idx + 1] as u16) << 8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence = note: `#[warn(clippy::precedence)]` on by default