clippy

Author: burrbull

src/flash.rs

@@ -63,7 +63,7 @@ pub struct FlashWriter<'a> {
     flash_sz: FlashSize,
     verify: bool,
 }
-impl<'a> FlashWriter<'a> {
+impl FlashWriter<'_> {
     fn unlock(&mut self) -> Result<()> {
         // Wait for any ongoing operations
         while self.flash.sr.sr().read().bsy().bit_is_set() {}
@@ -245,7 +245,7 @@ impl<'a> FlashWriter<'a> {
 
             // Flash is written 16 bits at a time, so combine two bytes to get a
             // half-word
-            let hword: u16 = (data[idx] as u16) | (data[idx + 1] as u16) << 8;
+            let hword: u16 = (data[idx] as u16) | ((data[idx + 1] as u16) << 8);
 
             // NOTE(unsafe) Write to FLASH area with no side effects
             unsafe { core::ptr::write_volatile(write_address, hword) };

src/gpio.rs

@@ -519,7 +519,6 @@ impl<const P: char, const N: u8, MODE> Pin<P, N, MODE> {
       before changing its mode to an output to avoid
       a short spike of an incorrect value
     */
-
     #[inline(always)]
     fn _set_state(&mut self, state: PinState) {
         match state {

src/i2c.rs

@@ -282,7 +282,7 @@ impl<I2C: Instance> I2c<I2C> {
     fn send_addr(&self, addr: u8, read: bool) {
         self.i2c
             .dr()
-            .write(|w| w.dr().set(addr << 1 | (u8::from(read))));
+            .write(|w| w.dr().set((addr << 1) | (u8::from(read))));
     }
 
     /// Generate STOP condition

src/rcc.rs

@@ -187,7 +187,6 @@ impl CFGR {
     /// let mut rcc = dp.RCC.constrain();
     /// let clocks = rcc.cfgr.freeze(&mut flash.acr);
     /// ```
-
     #[inline(always)]
     pub fn freeze(self, acr: &mut ACR) -> Clocks {
         let cfg = Config::from_cfgr(self);

src/rtc.rs

@@ -41,7 +41,6 @@ pub enum RestoredOrNewRtc<CS> {
   [examples/rtc.rs]: https://github.com/stm32-rs/stm32f1xx-hal/blob/v0.7.0/examples/rtc.rs
   [examples/blinky_rtc.rs]: https://github.com/stm32-rs/stm32f1xx-hal/blob/v0.7.0/examples/blinky_rtc.rs
 */
-
 pub struct Rtc<CS = RtcClkLse> {
     regs: RTC,
     _clock_source: PhantomData<CS>,
@@ -360,7 +359,7 @@ impl<CS> Rtc<CS> {
         // Wait for the APB1 interface to be ready
         while !self.regs.crl().read().rsf().bit() {}
 
-        self.regs.cnth().read().bits() << 16 | self.regs.cntl().read().bits()
+        (self.regs.cnth().read().bits() << 16) | self.regs.cntl().read().bits()
     }
 
     /// Enables triggering the RTC interrupt every time the RTC counter is increased