Skip to content

Conversation

burrbull
Copy link
Member

This is fast impl. Not tested.

cc @everdrone

@tmehr-enqt
Copy link
Contributor

What tests do you think have to be done? I did some quick tests with an spi loopback on a f103 nucleo. That worked. If you assume that the peripheries of the F series are basically all the same I would say it works.

@burrbull
Copy link
Member Author

burrbull commented Sep 1, 2025

spi loopback on a f103 nucleo

Have you used embedded-hal API for this?

@tmehr-enqt
Copy link
Contributor

tmehr-enqt commented Sep 1, 2025

I have now. Still as expected. Still I just tried one configuration of it and not with a real other device, just looping MOSI and MISO. However I'm assuming the the other stuff works just fine. Did you copy this implementation from f4xx too?

@tmehr-enqt
Copy link
Contributor

Maybe also add a allow for static_mut_refs so the spi-slave example doesn't generate warnings?

@burrbull
Copy link
Member Author

burrbull commented Sep 1, 2025

Maybe also add a allow for static_mut_refs so the spi-slave example doesn't generate warnings?

I'd replace static mut with something more safe, static-cell or other alternative. PRs are welcome.

@burrbull burrbull merged commit cb7cc07 into master Sep 1, 2025
12 checks passed
@tmehr-enqt tmehr-enqt deleted the spi-framesize branch September 10, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants