Check can with clippy and fix clippy lints

Author: Sh3Rm4n

.github/workflows/ci.yml

@@ -35,7 +35,7 @@ jobs:
         features: ["rt"]
         include:
           - mcu: stm32f303xc
-            features: rt,stm32-usbd
+            features: rt,stm32-usbd,can
     steps:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
@@ -65,7 +65,7 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           args: >
-            --features=stm32f303xc,rt,stm32-usbd --lib --examples
+            --features=stm32f303xc,rt,stm32-usbd,can --lib --examples
             -- -D warnings
 
   rustfmt:

examples/can.rs

@@ -81,7 +81,7 @@ fn main() -> ! {
             }
 
             let data: [u8; 1] = [counter];
-            let frame = CanFrame::data_frame(CanId::BaseId(ID.into()), &data);
+            let frame = CanFrame::data_frame(CanId::BaseId(ID), &data);
 
             block!(can_tx.transmit(&frame)).expect("Cannot send CAN frame");
         }

src/can.rs

@@ -17,7 +17,7 @@ use nb::{self, Error};
 
 use core::sync::atomic::{AtomicU8, Ordering};
 
-const EXID_MASK: u32 = 0b11111_11111100_00000000_00000000;
+const EXID_MASK: u32 = 0b1_1111_1111_1100_0000_0000_0000_0000;
 const MAX_EXTENDED_ID: u32 = 0x1FFF_FFFF;
 
 /// A CAN identifier, which can be either 11 or 27 (extended) bits.
@@ -302,7 +302,7 @@ impl Can {
             _tx: self._tx,
         };
 
-        return (transmitter, fifo0, fifo1);
+        (transmitter, fifo0, fifo1)
     }
 
     pub fn free(self) -> (stm32::CAN, gpioa::PA11<AF9>, gpioa::PA12<AF9>) {
@@ -353,7 +353,7 @@ impl embedded_hal_can::Transmitter for CanTransmitter {
                 }),
             }
 
-            if let Some(_) = frame.data() {
+            if frame.data().is_some() {
                 for j in 0..frame.data.len() {
                     let val = &frame.data[j];