clippy (#191)

* clippy

Author: usbalbin

src/adc.rs

@@ -83,7 +83,7 @@ impl Temperature {
     /// ## Arguments
     /// * `sample`: ADC sample taken on the [`Temperature`] channel.
     /// * `vdda`: Analog reference voltage (vref+) when the temperature
-    ///     sample was taken, in volts.
+    ///   sample was taken, in volts.
     /// * `resolution`: Configured ADC resolution.
     #[inline(always)]
     pub fn temperature_to_degrees_centigrade(
@@ -108,7 +108,7 @@ impl Temperature {
     /// ## Arguments
     /// * `sample`: ADC sample taken on the [`Temperature`] channel.
     /// * `vdda`: Analog reference voltage (vref+) when the temperature
-    ///     sample was taken, in millivolts.
+    ///   sample was taken, in millivolts.
     /// * `resolution`: Configured ADC resolution.
     #[inline(always)]
     pub fn temperature_to_degrees_centigrade_coarse(
@@ -1895,7 +1895,7 @@ macro_rules! adc {
                 /// * `channel` - channel to configure
                 /// * `sequence` - where in the sequence to sample the channel. Also called rank in some STM docs/code
                 /// * `sample_time` - how long to sample for. See datasheet and ref manual to work out how long you need\
-                ///     to sample for at a given ADC clock frequency
+                ///   to sample for at a given ADC clock frequency
                 pub fn configure_channel<CHANNEL>(&mut self, _channel: &CHANNEL, sequence: config::Sequence, sample_time: config::SampleTime)
                 where
                     CHANNEL: Channel<stm32::$adc_type, ID=u8>
@@ -2406,7 +2406,7 @@ macro_rules! adc {
                 /// * `channel` - channel to configure
                 /// * `sequence` - where in the sequence to sample the channel. Also called rank in some STM docs/code
                 /// * `sample_time` - how long to sample for. See datasheet and ref manual to work out how long you need\
-                ///     to sample for at a given ADC clock frequency
+                ///   to sample for at a given ADC clock frequency
                 #[inline(always)]
                 pub fn configure_channel<CHANNEL>(&mut self, channel: &CHANNEL, sequence: config::Sequence, sample_time: config::SampleTime)
                 where

src/serial/usart.rs

@@ -1,4 +1,4 @@
-use core::fmt;
+use core::fmt::{self, Debug};
 use core::marker::PhantomData;
 
 use crate::dma::{
@@ -139,20 +139,26 @@ pub trait SerialExt<USART, Config> {
 
 impl<USART, TX, RX> fmt::Write for Serial<USART, TX, RX>
 where
-    Serial<USART, TX, RX>: embedded_hal_old::serial::Write<u8>,
+    Self: embedded_hal_old::serial::Write<u8>,
+    <Self as embedded_hal_old::serial::Write<u8>>::Error: Debug,
 {
     fn write_str(&mut self, s: &str) -> fmt::Result {
-        let _ = s.as_bytes().iter().map(|c| block!(self.write(*c))).last();
+        for c in s.as_bytes() {
+            block!(self.write(*c)).unwrap(); // self.write does not fail
+        }
         Ok(())
     }
 }
 
 impl<USART, Pin, Dma> fmt::Write for Tx<USART, Pin, Dma>
 where
-    Tx<USART, Pin, Dma>: embedded_hal_old::serial::Write<u8>,
+    Self: embedded_hal_old::serial::Write<u8>,
+    <Self as embedded_hal_old::serial::Write<u8>>::Error: Debug,
 {
     fn write_str(&mut self, s: &str) -> fmt::Result {
-        let _ = s.as_bytes().iter().map(|c| block!(self.write(*c))).last();
+        for c in s.as_bytes() {
+            block!(self.write(*c)).unwrap(); // self.write does not fail
+        }
         Ok(())
     }
 }