Allow selecting any clock source when freezing rcc configuration #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@usbalbin once you are happy with this PR, I can do the same for all of the other peripheral clock sources. |
Member
|
LGTM |
Contributor
Author
|
I will do the other clock configs in another PR. Happy for this to be merged. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PCLK is is statically configured when the constructor for the FDCAN peripheral is called. This pull request adds selecting the clock source.
This also means the default clock source is HSE (the reset value) rather than PCLK. The
can-echoexample doesn't need to be updated as it assumes PCLK = HSE.