Impl rand_core::RngCore & support all integers in Rng #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olback
commented
Dec 2, 2021
mattico
reviewed
Dec 2, 2021
| fn fill(&mut self, dest: &mut [$type]) -> Result<(), ErrorKind> { | ||
| let len = dest.len() * (mem::size_of::<$type>() / mem::size_of::<u32>()); | ||
| let ptr = dest.as_mut_ptr() as *mut u32; | ||
| let slice_u32 = unsafe { core::slice::from_raw_parts_mut(ptr, len) }; |
There was a problem hiding this comment.
mem::align_of::<u32>() = 4
mem::align_of::<u64>() = 8
mem::align_of::<u128>() = 8
I don't think so. u64/u128 is 8-byte aligned which would be valid for 4-byte aligned values as well. https://doc.rust-lang.org/reference/type-layout.html#size-and-alignment
There was a problem hiding this comment.
Oh right, I hadn't seen the distinction between rng_core and rng_core_large.
richardeoin
approved these changes
Dec 4, 2021
There was a problem hiding this comment.
Looks good to me! Thanks @olback, and also @AlyoshaVasilieva @mattico for the reviews 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.