Add inner and inner_mut functions to peripherals where it's easy to do so#306
Add inner and inner_mut functions to peripherals where it's easy to do so#306mattico wants to merge 2 commits intostm32-rs:masterfrom
Conversation
…o so Where the registers are owned by a single struct and not shared amongst many channels, etc.
richardeoin
left a comment
There was a problem hiding this comment.
Agreed these are all reasonable and safe. Some are implemented on types that are typically consumed quickly (like FMC) and thus aren't particularly useful, but still ok to include.
I'll leave the PR open for a bit in case anyone else wants to comment
|
I just added methods to access the peripheral in a DMA |
|
I'm less keen on those methods to access the peripheral in a DMA Transfer. Whilst I see your argument, I'd like to get more experience with actually using the DMA API before deciding what to do. You're right that |
|
@mattico Do you mind if I pick only the first commit and merge that for now? |
|
@richardeoin fine with me! |
Where the registers are owned by a single struct and not shared amongst many channels, etc.
Fixes #232