Skip to content

Fix SNR read. #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newAM merged 2 commits into from
Apr 20, 2025
Merged

Fix SNR read. #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7129f62
Fix SNR read.
Apr 17, 2025
a52a3cb
Add changelog entry
newAM Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Added a missing `must_use` in `SleepCfg::set_startup`.

### Changed
- Renamed function TcxoMode::set_txco_trim() to TcxoMode::set_tcxo_trim() to correct spelling.
- Renamed enum CmdStatus::Avaliable to CmdStatus::Available to correct spelling.
- Updated minimum `chrono` version to `0.4.23` to satisfy `cargo-audit`.
- Changed the edition from 2021 to 2024.
- Changed minimum supported rust version from 1.60 to 1.85.

### Fixed
- Added a missing `must_use` in `SleepCfg::set_startup`.
- Fixed an incorrect cast from `u8` to `i16` in `LoRaPacketStatus::snr_pkt`
- Renamed function `TcxoMode::set_txco_trim` to `TcxoMode::set_tcxo_trim` to fix spelling.
- Renamed enum `CmdStatus::Avaliable` to `CmdStatus::Available` to fix spelling.

## [0.6.1] - 2022-08-01
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion hal/src/subghz/packet_status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl LoRaPacketStatus {
/// assert_eq!(pkt_status.snr_pkt().to_integer(), 10);
/// ```
pub fn snr_pkt(&self) -> Ratio<i16> {
Ratio::new_raw(i16::from(self.buf[2]), 4)
Ratio::new_raw(i16::from(self.buf[2] as i8), 4)
}

/// Estimation of RSSI level of the LoRa signal after despreading.
Expand Down